Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Refactor Composer Dropdown #27931

Merged
merged 10 commits into from
Feb 9, 2023
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Feb 1, 2023

DSA-21

Proposed changes (including videos or screenshots)

Screen Shot 2023-02-01 at 17 59 31

Issue(s)

Closes #21196

Steps to test or reproduce

Further comments

@dougfabris dougfabris marked this pull request as ready for review February 8, 2023 17:20
@dougfabris dougfabris requested a review from a team as a code owner February 8, 2023 17:20
@dougfabris dougfabris requested a review from a team as a code owner February 8, 2023 22:58
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #27931 (abe6949) into develop (7f507c1) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

❗ Current head abe6949 differs from pull request most recent head de01cbc. Consider uploading reports for the commit de01cbc to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27931      +/-   ##
===========================================
- Coverage    42.03%   41.62%   -0.41%     
===========================================
  Files          848      849       +1     
  Lines        17555    17557       +2     
  Branches      2078     2087       +9     
===========================================
- Hits          7379     7308      -71     
- Misses        9898     9977      +79     
+ Partials       278      272       -6     
Flag Coverage Δ
e2e 41.62% <100.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 9, 2023
@ggazzo ggazzo merged commit d475a60 into develop Feb 9, 2023
@ggazzo ggazzo deleted the chore/refactor-composer-dropdown branch February 9, 2023 14:42
gabriellsh added a commit that referenced this pull request Feb 13, 2023
…e/wizard

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [BREAK] Unify monolith and microservices intercommunication on same technology and limit to Enterprise only (#27969)
  [NEW] Emojis rendering properly on quote message previews (#27972)
  Chore: Wait message to not be Busy (#28000)
  Chore: e2e changes tests (#27987)
  [IMPROVE] Audit (#27994)
  [IMPROVE] Registration Experience (#27820)
  [BREAK][ENTERPRISE] Limit presence statuses to 200 concurrent users when running monolith to keep performance (#27854)
  [BREAK] Removed deprecated settings for Legacy Messages, Marked, Snippet Messages, Autolinker and IssueLinks (#27902)
  [NEW] Permission to bypass message editing and removing limits (#27644)
  [FIX] Video Conf Message Blocks not always updating when running on micro services (#27764)
  Chore: Set missing colors (#27817)
  Fix CI
  Chore: undo busy selector
  [BREAK] Remove message view mode from User Preferences (#27867)
  Chore: Aria busy indicators (#27978)
  Chore: Refactor Composer Dropdown (#27931)
  Chore: Added Enterprise Options to Login customization (#27855)
  [FIX] Ignored messages reactivity (#27279)
  [BREAK] [NEW] Custom roles upsell modal (#27707)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@dougfabris dougfabris added this to the 6.0.0 milestone Feb 23, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Message Box, Pop over text don't have hover effect.
2 participants